Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2632543002: Don't clobber SocketError's OSError on failed write and send. (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't clobber SocketError's OSError on failed write and send. related #25342 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/deb21810678f71c68aa95253a917e18ce0a2798a

Patch Set 1 #

Patch Set 2 : Really fix it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/bin/socket_patch.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
3 years, 11 months ago (2017-01-12 23:31:59 UTC) #2
siva
lgtm
3 years, 11 months ago (2017-01-12 23:43:10 UTC) #3
siva
lgtm
3 years, 11 months ago (2017-01-12 23:45:41 UTC) #4
zra
3 years, 11 months ago (2017-01-12 23:51:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
deb21810678f71c68aa95253a917e18ce0a2798a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698