Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 263253002: Make WebWidget::compositeAndReadbackAsync() return void. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, enne (OOO)
Visibility:
Public.

Description

Make WebWidget::compositeAndReadbackAsync() return void. This method returns false when isAcceleratedCompositingActive() is not enabled. In the future this will always be enabled (at least for callers of the compositeAndReadbackAsync() method), so having to support a branch and NOTREACHED() at each call site it awkward. Instead make this method ASSSERT(isAcceleratedCompositingActive()) and not return a value. R=abarth BUG=251960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173572

Patch Set 1 #

Patch Set 2 : voidcompositeAndReadbackAsync: void #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M public/web/WebWidget.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
6 years, 7 months ago (2014-05-05 22:31:20 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-05-05 22:38:22 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-07 21:40:23 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 7 months ago (2014-05-07 21:40:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/263253002/1
6 years, 7 months ago (2014-05-07 21:40:57 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-07 22:06:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/263253002/20001
6 years, 7 months ago (2014-05-07 22:06:54 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 23:12:59 UTC) #8
Message was sent while issue was closed.
Change committed as 173572

Powered by Google App Engine
This is Rietveld 408576698