Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/access-info.cc

Issue 2632503003: [runtime] Allocate space for computed property names (Closed)
Patch Set: Fix some variable names. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/compilation-dependencies.h" 8 #include "src/compilation-dependencies.h"
9 #include "src/compiler/access-info.h" 9 #include "src/compiler/access-info.h"
10 #include "src/compiler/type-cache.h" 10 #include "src/compiler/type-cache.h"
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 384
385 // Don't search on the prototype chain for special indices in case of 385 // Don't search on the prototype chain for special indices in case of
386 // integer indexed exotic objects (see ES6 section 9.4.5). 386 // integer indexed exotic objects (see ES6 section 9.4.5).
387 if (map->IsJSTypedArrayMap() && name->IsString() && 387 if (map->IsJSTypedArrayMap() && name->IsString() &&
388 IsSpecialIndex(isolate()->unicode_cache(), String::cast(*name))) { 388 IsSpecialIndex(isolate()->unicode_cache(), String::cast(*name))) {
389 return false; 389 return false;
390 } 390 }
391 391
392 // Don't search on the prototype when storing in literals 392 // Don't search on the prototype when storing in literals
393 if (access_mode == AccessMode::kStoreInLiteral) { 393 if (access_mode == AccessMode::kStoreInLiteral) {
394 return LookupTransition(receiver_map, name, holder, access_info);
394 return false; 395 return false;
Toon Verwaest 2017/01/18 08:49:53 drop return false
Franzi 2017/01/18 14:23:10 Done.
395 } 396 }
396 397
397 // Don't lookup private symbols on the prototype chain. 398 // Don't lookup private symbols on the prototype chain.
398 if (name->IsPrivate()) return false; 399 if (name->IsPrivate()) return false;
399 400
400 // Walk up the prototype chain. 401 // Walk up the prototype chain.
401 if (!map->prototype()->IsJSObject()) { 402 if (!map->prototype()->IsJSObject()) {
402 // Perform the implicit ToObject for primitives here. 403 // Perform the implicit ToObject for primitives here.
403 // Implemented according to ES6 section 7.3.2 GetV (V, P). 404 // Implemented according to ES6 section 7.3.2 GetV (V, P).
404 Handle<JSFunction> constructor; 405 Handle<JSFunction> constructor;
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 } 559 }
559 return false; 560 return false;
560 } 561 }
561 562
562 563
563 Factory* AccessInfoFactory::factory() const { return isolate()->factory(); } 564 Factory* AccessInfoFactory::factory() const { return isolate()->factory(); }
564 565
565 } // namespace compiler 566 } // namespace compiler
566 } // namespace internal 567 } // namespace internal
567 } // namespace v8 568 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698