Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2632493005: Disable Android virtual keyboard when in VR shell (Closed)
Patch Set: Disable Android virtual keyboard when in VR shell Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_shell.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc
index b1fe6a972ce10b6ccc885b556a1f2c98ab746918..551cd649fc14d4aea0fb8e9ef1b33a610c6ac1fa 100644
--- a/chrome/browser/android/vr_shell/vr_shell.cc
+++ b/chrome/browser/android/vr_shell/vr_shell.cc
@@ -149,7 +149,7 @@ VrShell::VrShell(JNIEnv* env,
vr_web_contents_observer_.reset(new VrWebContentsObserver(
main_contents, html_interface_.get(), this));
- SetShowingOverscrollGlow(false);
+ SetIsInVR(true);
}
void VrShell::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
@@ -209,7 +209,7 @@ void VrShell::OnPause(JNIEnv* env, const JavaParamRef<jobject>& obj) {
// exit vr session
metrics_helper_->SetVRActive(false);
- SetShowingOverscrollGlow(true);
+ SetIsInVR(false);
}
void VrShell::OnResume(JNIEnv* env, const JavaParamRef<jobject>& obj) {
@@ -219,7 +219,7 @@ void VrShell::OnResume(JNIEnv* env, const JavaParamRef<jobject>& obj) {
// exit vr session
bshe 2017/01/17 12:26:15 nit: not related to your change, but do you mind r
metrics_helper_->SetVRActive(true);
- SetShowingOverscrollGlow(false);
+ SetIsInVR(true);
}
void VrShell::SetSurface(JNIEnv* env,
@@ -234,9 +234,8 @@ void VrShell::SetSurface(JNIEnv* env,
base::Unretained(window)));
}
-void VrShell::SetShowingOverscrollGlow(bool showing_glow) {
- main_contents_->GetRenderWidgetHostView()->SetShowingOverscrollGlow(
- showing_glow);
+void VrShell::SetIsInVR(bool is_in_vr) {
+ main_contents_->GetRenderWidgetHostView()->SetIsInVR(is_in_vr);
}
base::WeakPtr<VrShell> VrShell::GetWeakPtr(
« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell.h ('k') | chrome/browser/android/vr_shell/vr_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698