Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java

Issue 2632493003: [Android History] Styling changes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
index e50ae71127ffc3d45ddd8c118c6308e92e00cc20..605e510925ce237f1afb001c62ca357111254bca 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.history;
import android.content.Context;
+import android.graphics.Color;
import android.text.Editable;
import android.text.TextUtils;
import android.text.TextWatcher;
@@ -146,12 +147,14 @@ public class HistoryManagerToolbar extends SelectionToolbar<HistoryItem>
mSearchView.setVisibility(View.VISIBLE);
getMenu().setGroupVisible(mNormalGroupResId, false);
setNavigationButton(NAVIGATION_BUTTON_BACK);
+ setBackgroundColor(Color.WHITE);
gone 2017/01/13 18:27:48 Does this have to be undone in the above part of t
Theresa 2017/01/13 19:40:28 Done. It was working, but as discussed offline it'
}
}
@Override
protected void onDataChanged(int numItems) {
- getMenu().findItem(R.id.search_menu_id).setVisible(!mIsSearching && numItems != 0);
+ getMenu().findItem(R.id.search_menu_id).setVisible(
+ !mIsSelectionEnabled && !mIsSearching && numItems != 0);
}
@Override
@@ -205,7 +208,12 @@ public class HistoryManagerToolbar extends SelectionToolbar<HistoryItem>
}
@VisibleForTesting
- Menu getMenuForTest() {
+ Menu getMenuForTests() {
return getMenu();
}
+
+ @VisibleForTesting
+ View getSearchViewForTests() {
+ return mSearchView;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698