VM: Avoid running atexit() handlers during exit() of a failed subprocess spawn

VM: Avoid running atexit() handlers during exit() of a failed subprocess spawn

Somtimes execve() fails and then we fall back to exit(1) in the fork()ed but not
exeve()ed subprocess.

One of the issues is e.g. that we don't want to run LSAN in the fork()ed but not
execve()ed subprocess, the results will be bogus (plus the output of
LSAN is not read on the other side (i.e. the unix pipe is not drained) which
blocks the subprocess indefinitely).

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5dc73cacd207ff07fb6055cee8370f1f2a9e01e7

[kustermann, 2017-01-12 13:18:10]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2017-01-12 13:18:43]

lgtm

[kustermann, 2017-01-12 13:20:41]

Description was changed from

==========
VM: Avoid running atexit() handlers during exit() of a failed subprocess spawn

Somtimes execve() fails and then we fall back to exit(1) in the fork()ed but not
exeve()ed subprocess.

One of the issues is e.g. that we don't want to run LSAN in the fork()ed but not
execve()ed subprocess, the results will be bogus (plus the output of
LSAN is not read on the other side (i.e. the unix pipe is not drained) which
blocks the subprocess indefinitely).
==========

to

==========
VM: Avoid running atexit() handlers during exit() of a failed subprocess spawn

Somtimes execve() fails and then we fall back to exit(1) in the fork()ed but not
exeve()ed subprocess.

One of the issues is e.g. that we don't want to run LSAN in the fork()ed but not
execve()ed subprocess, the results will be bogus (plus the output of
LSAN is not read on the other side (i.e. the unix pipe is not drained) which
blocks the subprocess indefinitely).

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5dc73cacd207ff07fb6055cee8370f1f2a9e01e7
==========

[kustermann, 2017-01-12 13:20:42]

Committed patchset #1 (id:1) manually as
5dc73cacd207ff07fb6055cee8370f1f2a9e01e7 (presubmit successful).