Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: cc/debug/debug_rect_history.cc

Issue 2632463005: cc: Ensure that large damage doesn't register as "frame has no damage" (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/render_surface_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/debug_rect_history.cc
diff --git a/cc/debug/debug_rect_history.cc b/cc/debug/debug_rect_history.cc
index de8bfc2cc2f84f5922837b9d3fc31ff0d98dceb5..8472c28f7f95c84a400299fccb67897804a61424 100644
--- a/cc/debug/debug_rect_history.cc
+++ b/cc/debug/debug_rect_history.cc
@@ -125,11 +125,15 @@ void DebugRectHistory::SaveSurfaceDamageRects(
RenderSurfaceImpl* render_surface = render_surface_layer->render_surface();
DCHECK(render_surface);
- debug_rects_.push_back(DebugRect(
- SURFACE_DAMAGE_RECT_TYPE,
- MathUtil::MapEnclosingClippedRect(
- render_surface->screen_space_transform(),
- render_surface->damage_tracker()->current_damage_rect())));
+ gfx::Rect damage_rect;
+ bool is_valid_rect =
+ render_surface->damage_tracker()->GetDamageRectIfValid(&damage_rect);
enne (OOO) 2017/01/20 22:15:13 Maybe use RenderSurfaceImpl::GetDamageRect here?
vmpstr 2017/01/20 22:41:51 Err missed this one, thanks
+ if (!is_valid_rect)
+ damage_rect = render_surface->content_rect();
+ debug_rects_.push_back(
+ DebugRect(SURFACE_DAMAGE_RECT_TYPE,
+ MathUtil::MapEnclosingClippedRect(
+ render_surface->screen_space_transform(), damage_rect)));
}
}
« no previous file with comments | « no previous file | cc/layers/render_surface_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698