Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2632393003: Improve range-operation documentation for lists. (Closed)

Created:
3 years, 11 months ago by floitsch
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve range-operation documentation for lists. Fixes #26332 BUG= http://dartbug.com/26332 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/c2096b8bf967c3b85751e4a01a0713b39e67cb66

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M sdk/lib/core/list.dart View 1 5 chunks +27 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
3 years, 11 months ago (2017-01-17 14:23:32 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2632393003/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/2632393003/diff/1/sdk/lib/core/list.dart#newcode426 sdk/lib/core/list.dart:426: * That is, it does *not* throw exceptions ...
3 years, 11 months ago (2017-01-17 15:56:59 UTC) #3
floitsch
https://codereview.chromium.org/2632393003/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/2632393003/diff/1/sdk/lib/core/list.dart#newcode426 sdk/lib/core/list.dart:426: * That is, it does *not* throw exceptions if ...
3 years, 11 months ago (2017-01-18 12:54:19 UTC) #4
floitsch
3 years, 11 months ago (2017-01-18 12:54:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c2096b8bf967c3b85751e4a01a0713b39e67cb66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698