ios/chrome/widget_extension/Info.plist - Issue 2632333002: Add a prototype today extension behind gn flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/widget_extension/Info.plist

Issue 2632333002: Add a prototype today extension behind gn flag (Closed)

Patch Set: renaming Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/widget_extension/BUILD.gn ('K') | « ios/chrome/widget_extension/BUILD.gn ('k') | ios/chrome/widget_extension/entitlements/external/widget_extension.appex.entitlements » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>

	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

	3 <plist version="1.0">

	4 <dict>

	5 <key>CFBundleDevelopmentRegion</key>

	6 <string>en</string>

	7 <key>CFBundleDisplayName</key>

	8 <string>${CHROMIUM_SHORT_NAME}</string>

	9 <key>CFBundleExecutable</key>

	10 <string>proto_today_extension</string>

	11 <key>CFBundleIdentifier</key>

	12 <string>${IOS_BUNDLE_ID_PREFIX}.${TODAY_EXTENSION_BUNDLE_ID}</string>
	sdefresne 2017/01/18 11:11:35 I would rename TODAY_EXTENSION_BUNDLE_ID to WIDGET I would rename TODAY_EXTENSION_BUNDLE_ID to WIDGET_EXTENSION_BUNDLE_ID here too. lody 2017/01/18 14:56:39 Done. Show quoted text On 2017/01/18 11:11:35, sdefresne wrote: > I would rename TODAY_EXTENSION_BUNDLE_ID to WIDGET_EXTENSION_BUNDLE_ID here too. Done.
	13 <key>CFBundleInfoDictionaryVersion</key>

	14 <string>6.0</string>

	15 <key>CFBundleName</key>

	16 <string>proto_today_extension</string>

	17 <key>CFBundlePackageType</key>

	18 <string>XPC!</string>

	19 <key>CFBundleShortVersionString</key>

	20 <string>1.0</string>

	21 <key>CFBundleSignature</key>

	22 <string>????</string>

	23 <key>CFBundleVersion</key>

	24 <string>1</string>

	25 <key>NSExtension</key>

	26 <dict>

	27 <key>NSExtensionPrincipalClass</key>

	28 <string>WidgetViewController</string>

	29 <key>NSExtensionPointIdentifier</key>

	30 <string>com.apple.widget-extension</string>

	31 </dict>

	32 <key>KSChannelChromeScheme</key>

	33 <string>${CHROME_CHANNEL_SCHEME}</string>

	34 </dict>

	35 </plist>

OLD	NEW