Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: ios/chrome/proto_today_extension/widget_view_controller.mm

Issue 2632333002: Add a prototype today extension behind gn flag (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 #import "ios/chrome/proto_today_extension/widget_view_controller.h"
Olivier 2017/01/17 10:13:05 Add space before
lody 2017/01/17 17:31:46 Done.
5
6 #import <NotificationCenter/NotificationCenter.h>
7
8 #import "ios/chrome/proto_today_extension/widget_view.h"
9
10 @interface WidgetViewController ()
11 @property(nonatomic) WidgetView* widgetView;
Olivier 2017/01/17 10:13:05 Is this ARC?
lody 2017/01/17 17:31:46 now it is! ;)
12 @end
13
14 @implementation WidgetViewController
15
16 @synthesize widgetView = _widgetView;
17
18 #pragma mark - UIViewController
19
20 - (void)viewDidLoad {
21 [super viewDidLoad];
22
23 [self setWidgetView:[[WidgetView alloc] init]];
sdefresne 2017/01/17 10:39:07 This leaks unless you're using ARC (which you are
lody 2017/01/17 17:31:46 leak fixed. regarding using properties syntax, is
24 [self.view addSubview:_widgetView];
25 }
26
27 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698