Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: ios/chrome/proto_today_extension/BUILD.gn

Issue 2632333002: Add a prototype today extension behind gn flag (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 import("//build/config/ios/rules.gni")
6 import("//build/mac/tweak_info_plist.gni")
7 import("//ios/build/chrome_build.gni")
8
9 tweak_info_plist("tweak_info_plist") {
10 info_plist = "Info.plist"
11 }
12
13 compile_plist("entitlements") {
14 format = "xml1"
15 substitutions = [ "IOS_BUNDLE_ID_PREFIX=$ios_app_bundle_id_prefix" ]
16 output_name = "$target_gen_dir/proto_today_extension.appex.entitlements"
17 plist_templates = [ "../today_extension/entitlements/external/today_extension. appex.entitlements" ] + ios_chrome_entitlements_additions
Olivier 2017/01/17 10:13:05 proto_today_extension
Olivier 2017/01/17 10:13:05 You have to use the same appex name everywhere.
sdefresne 2017/01/17 10:39:07 Why not just copy the file from ios/today_extensio
lody 2017/01/17 17:31:45 Not sure what you mean by "Then you won't have to
18 }
19
20 ios_appex_bundle("proto_today_extension") {
21 sources = [
22 "widget_view.h",
23 "widget_view.mm",
24 "widget_view_controller.h",
25 "widget_view_controller.mm",
26 ]
27
28 libs = [
29 "Foundation.framework",
30 "NotificationCenter.framework",
31 "UIKit.framework",
32 ]
33
34 extra_substitutions = [
35 "CHROME_CHANNEL_SCHEME=$url_channel_scheme",
36 "CHROMIUM_SHORT_NAME=$chromium_short_name",
37 "TODAY_EXTENSION_BUNDLE_ID=$chromium_bundle_id.TodayExtension",
38 ]
39
sdefresne 2017/01/17 10:39:07 It is recommended to use ARC for new code, so:
40 entitlements_target = ":entitlements"
41 info_plist_target = ":tweak_info_plist"
42 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698