macOS: Adding tooltip in the profile chooser

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #import <Carbon/Carbon.h>  // kVK_Return.
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
@@ skipping 2120 matching lines @@
         setImage:NSImageFromImageSkia(gfx::CreateVectorIcon(
                      badgeIcon, badgeIconSize, gfx::kChromeIconGrey))];
     [badgeIconWithCircle addSubview:badgeIconView];
 
     [profileCard addSubview:badgeIconWithCircle];
   }
 
   // Profile name, left-aligned to the right of profile icon.
   xOffset += kMdImageSide + kHorizontalSpacing;
   CGFloat fontSize = kTextFontSize + 1.0;
-  NSTextField* profileName =
-      BuildLabel(base::SysUTF16ToNSString(profileNameString), NSZeroPoint, nil);
+  NSString* profileNameNSString = base::SysUTF16ToNSString(profileNameString);
+  NSTextField* profileName = BuildLabel(profileNameNSString, NSZeroPoint, nil);
   [[profileName cell] setLineBreakMode:NSLineBreakByTruncatingTail];
   [profileName setFont:[NSFont labelFontOfSize:fontSize]];
   [profileName sizeToFit];
   const int profileNameYOffset =
       cardYOffset +
       std::floor((kMdImageSide - NSHeight([profileName frame])) / 2);
+  if (profileName.frame.size.width > availableTextWidth) {
+    // Add the tooltip only if the profile name is truncated. This method to
+    // test if text field is truncated is not ideal (spaces between characters
+    // can be reduced without truncated).

[msarda, 2017/01/17 14:01:33]

s/can be reduced without truncated/may be reduced to avoid truncation

[jlebel, 2017/01/17 14:16:54]

Done.

+    profileName.toolTip = profileNameNSString;
+  }
   [profileName
       setFrame:NSMakeRect(xOffset, profileNameYOffset, availableTextWidth,
                           NSHeight([profileName frame]))];
   [profileCard addSubview:profileName];
 
   // Username, left-aligned to the right of profile icon and below the profile
   // name.
   if (item.signed_in && !switches::IsEnableAccountConsistency()) {
     // Adjust the y-position of profile name to leave space for username.
     cardYOffset += kMdImageSide / 2 - [profileName frame].size.height;
     [profileName setFrameOrigin:NSMakePoint(xOffset, cardYOffset)];
 
+    NSString* elideEmail =

[msarda, 2017/01/17 14:01:33]

Nit: s/elideEmail/elidedEmail

[jlebel, 2017/01/17 14:16:54]

Done.

+        ElideEmail(base::UTF16ToUTF8(item.username), availableTextWidth);
     NSTextField* username = BuildLabel(
-        ElideEmail(base::UTF16ToUTF8(item.username), availableTextWidth),
-        NSZeroPoint, skia::SkColorToSRGBNSColor(SK_ColorGRAY));
+        elideEmail, NSZeroPoint, skia::SkColorToSRGBNSColor(SK_ColorGRAY));
     [username setFrameOrigin:NSMakePoint(xOffset, NSMaxY([profileName frame]))];
+    NSString* usernameNSString = base::SysUTF16ToNSString(item.username);
+    if (![[username stringValue] isEqualToString:usernameNSString]) {
+      // Add the tooltip only if the user name is truncated.
+      username.toolTip = usernameNSString;
+    }
     [profileCard addSubview:username];
   }
 
   yOffset = NSMaxY([profileCard frame]);
   [container setFrameSize:NSMakeSize(GetFixedMenuWidth(), yOffset)];
   return container.autorelease();
 }
 
 - (NSView*)createCurrentProfileLinksForItem:(const AvatarMenu::Item&)item
                                        rect:(NSRect)rect {
@@ skipping 764 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end