macOS: Adding tooltip in the profile chooser

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #import <Carbon/Carbon.h>  // kVK_Return.
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
@@ skipping 2128 matching lines @@
   xOffset += kMdImageSide + kHorizontalSpacing;
   CGFloat fontSize = kTextFontSize + 1.0;
   NSTextField* profileName =
       BuildLabel(base::SysUTF16ToNSString(profileNameString), NSZeroPoint, nil);
   [[profileName cell] setLineBreakMode:NSLineBreakByTruncatingTail];
   [profileName setFont:[NSFont labelFontOfSize:fontSize]];
   [profileName sizeToFit];
   const int profileNameYOffset =
       cardYOffset +
       std::floor((kMdImageSide - NSHeight([profileName frame])) / 2);
+  if (profileName.frame.size.width > availableTextWidth) {
+    // Add the tooltip only if the profile name is truncated. This method to
+    // test if text field is truncated is not ideal (spaces between characters
+    // can be reduced without truncated).
+    profileName.toolTip = base::SysUTF16ToNSString(profileNameString);

[msarda, 2017/01/17 13:26:44]

profileNameString is converted from NSString to UTF16 string 2 times - please
use an local variable for it.

[jlebel, 2017/01/17 13:54:28]

Done.

+  }
   [profileName
       setFrame:NSMakeRect(xOffset, profileNameYOffset, availableTextWidth,
                           NSHeight([profileName frame]))];
   [profileCard addSubview:profileName];
 

[msarda, 2017/01/17 13:26:44]

Have you tried using the same test as for the username below here (and removing
the test above)?
if (![[profileName stringValue]
    isEqualToString:base::SysUTF16ToNSString(profileNameString)])
  profileName.toolTip = base::SysUTF16ToNSString(profileNameString);
}

[jlebel, 2017/01/17 13:54:28]

-[NSTextField stringValue] returns the value given, and not the string
displayed. I was not able to find any API to know if the text has been elide.

For the version below, we elide ourselves the string. So we know if it has been
done. But it is better to let the OS do it, since it tries first change the
spaces between letters before eliding the string, so I think it is better to
leave the profile name the way it is.

   // Username, left-aligned to the right of profile icon and below the profile
   // name.
   if (item.signed_in && !switches::IsEnableAccountConsistency()) {
     // Adjust the y-position of profile name to leave space for username.
     cardYOffset += kMdImageSide / 2 - [profileName frame].size.height;
     [profileName setFrameOrigin:NSMakePoint(xOffset, cardYOffset)];
 
     NSTextField* username = BuildLabel(
         ElideEmail(base::UTF16ToUTF8(item.username), availableTextWidth),
         NSZeroPoint, skia::SkColorToSRGBNSColor(SK_ColorGRAY));
     [username setFrameOrigin:NSMakePoint(xOffset, NSMaxY([profileName frame]))];
+    if (![[username stringValue]
+            isEqualToString:base::SysUTF16ToNSString(item.username)]) {
+      // Add the tooltip only if the user name is truncated.
+      username.toolTip = base::SysUTF16ToNSString(item.username);

[msarda, 2017/01/17 13:26:44]

base::SysUTF16ToNSString(item.username) is converted from a NSString to a UTF16
string 3 times. Please add a local variable for it.

[jlebel, 2017/01/17 13:54:28]

Done.

+    }
     [profileCard addSubview:username];
   }
 
   yOffset = NSMaxY([profileCard frame]);
   [container setFrameSize:NSMakeSize(GetFixedMenuWidth(), yOffset)];
   return container.autorelease();
 }
 
 - (NSView*)createCurrentProfileLinksForItem:(const AvatarMenu::Item&)item
                                        rect:(NSRect)rect {
@@ skipping 764 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end