Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic.cc

Issue 2632253003: Bluetooth: macOS: Replacing BluetoothRemoteGattCharacteristicMac::StartNotifySession() by Bluetooth… (Closed)
Patch Set: Comments from Giovanni Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
index 8c94e7a5a64609be5e95beced0948ea2caeaf53c..3be984a7ae7ffd9256deebabde1c937f9209b8d0 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
@@ -145,15 +145,14 @@ void BluetoothRemoteGattCharacteristic::ExecuteStartNotifySession(
// rid of the entire check, and run SubscribeToNotifications on all
// platforms.
//
-// TODO(http://crbug.com/633191): Remove OS_MACOSX from this check.
// TODO(http://crbug.com/636270): Remove OS_WIN from this check.
-#if defined(OS_MACOSX) || defined(OS_WIN)
+#if defined(OS_WIN)
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(&BluetoothRemoteGattCharacteristic::OnStartNotifySessionError,
GetWeakPtr(), error_callback,
BluetoothRemoteGattService::GATT_ERROR_NOT_SUPPORTED));
-#else // !(defined(OS_MACOSX) || defined(OS_WIN))
+#else // defined(OS_WIN))
// Find the Client Characteristic Configuration descriptor.
std::vector<BluetoothRemoteGattDescriptor*> ccc_descriptor =
GetDescriptorsByUUID(BluetoothRemoteGattDescriptor::
@@ -183,7 +182,7 @@ void BluetoothRemoteGattCharacteristic::ExecuteStartNotifySession(
GetWeakPtr(), callback),
base::Bind(&BluetoothRemoteGattCharacteristic::OnStartNotifySessionError,
GetWeakPtr(), error_callback));
-#endif // defined(OS_MACOSX) || defined(OS_WIN)
+#endif // defined(OS_WIN)
}
void BluetoothRemoteGattCharacteristic::CancelStartNotifySession(

Powered by Google App Engine
This is Rietveld 408576698