VM: [Kernel] Partial support for metadata annotations

VM: [Kernel] Partial support for metadata annotations

The CL adds metadata support for Fields/Classes/Functions/Constructors. There
are other places where annotations can be put in the Dart language but the
Kernel IR currently does not store it in the AST.

Whenever a element (e.g. a function) gets annotated, the VM will make a [Field] for this
element whos value is an array of evaluated constant metadata annotations.

This CL attaches to these [Fields] a `kernel_function` which is then used to do the constant
evaluation.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e97bcc547551f1c0922c96351a02f43cc84149fb

[kustermann, 2017-01-16 14:40:11]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2017-01-17 22:33:06]

lgtm

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5897: ConstantEvaluator constant_evaluator(NULL /*
flow graph builder */, Z,
Most often we use 

/*builder=*/NULL

kind of comments to give it a feel of named parameters.

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5940: ConstantEvaluator constant_evaluator(NULL /*
flow graph builder */, Z,
ditto

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5970: /* FIXME: No parameter metadata support ATM */
please file a bug (against dartk?) and use // TODO(issue-number) here instead of
the FIXME.

https://codereview.chromium.org/2632253002/diff/1/tests/co19/co19-kernel.status
File tests/co19/co19-kernel.status (right):

https://codereview.chromium.org/2632253002/diff/1/tests/co19/co19-kernel.stat...
tests/co19/co19-kernel.status:11: Language/Metadata/before_export_t01:
RuntimeError  # Kernel IR misses these annotations.
# Dartk issue #XYZ

or

# Kernel issue #XYZ

[kustermann, 2017-01-18 09:34:41]

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5897: ConstantEvaluator constant_evaluator(NULL /*
flow graph builder */, Z,
On 2017/01/17 22:33:05, Vyacheslav Egorov (Google) wrote:
> Most often we use 
> 
> /*builder=*/NULL
> 
> kind of comments to give it a feel of named parameters.

Done.

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5940: ConstantEvaluator constant_evaluator(NULL /*
flow graph builder */, Z,
On 2017/01/17 22:33:05, Vyacheslav Egorov (Google) wrote:
> ditto

Done.

https://codereview.chromium.org/2632253002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:5970: /* FIXME: No parameter metadata support ATM */
On 2017/01/17 22:33:05, Vyacheslav Egorov (Google) wrote:
> please file a bug (against dartk?) and use // TODO(issue-number) here instead
of
> the FIXME.

Done.

https://codereview.chromium.org/2632253002/diff/1/tests/co19/co19-kernel.status
File tests/co19/co19-kernel.status (right):

https://codereview.chromium.org/2632253002/diff/1/tests/co19/co19-kernel.stat...
tests/co19/co19-kernel.status:11: Language/Metadata/before_export_t01:
RuntimeError  # Kernel IR misses these annotations.
On 2017/01/17 22:33:05, Vyacheslav Egorov (Google) wrote:
> # Dartk issue #XYZ
> 
> or
> 
> # Kernel issue #XYZ

Done.

[kustermann, 2017-01-18 09:51:34]

Description was changed from

==========
VM: [Kernel] Partial support for metadata annotations

The CL adds metadata support for Fields/Classes/Functions/Constructors. There
are other places where annotations can be put in the Dart language but the
Kernel IR currently does not store it in the AST.

Whenever a element (e.g. a function) gets annotated, the VM will make a [Field]
for this
element whos value is an array of evaluated constant metadata annotations.

This CL attaches to these [Fields] a `kernel_function` which is then used to do
the constant
evaluation.
==========

to

==========
VM: [Kernel] Partial support for metadata annotations

The CL adds metadata support for Fields/Classes/Functions/Constructors. There
are other places where annotations can be put in the Dart language but the
Kernel IR currently does not store it in the AST.

Whenever a element (e.g. a function) gets annotated, the VM will make a [Field]
for this
element whos value is an array of evaluated constant metadata annotations.

This CL attaches to these [Fields] a `kernel_function` which is then used to do
the constant
evaluation.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e97bcc547551f1c0922c96351a02f43cc84149fb
==========

[kustermann, 2017-01-18 09:51:36]

Committed patchset #2 (id:20001) manually as
e97bcc547551f1c0922c96351a02f43cc84149fb (presubmit successful).