Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2632243004: Don't download identical APKs on update. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 1384c5997f700cfa52b0ab58ec16c26684fcbb19..eb19a21651566eaca2cf65be69c66a714a289d92 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -418,6 +418,12 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
}
GURL signed_download_url(response->signed_download_url());
+ // https://crbug.com/680131. Don't download identical APKs on update.
pkotwicz 2017/01/17 02:37:10 How about: "The server sends an empty URL if the s
Xi Han 2017/01/17 16:45:12 Done.
+ if (task_type_ == UPDATE && signed_download_url.is_empty()) {
+ OnSuccess();
+ return;
+ }
+
if (!signed_download_url.is_valid() || response->package_name().empty()) {
OnFailure();
return;
« no previous file with comments | « chrome/browser/android/webapk/webapk.proto ('k') | chrome/browser/android/webapk/webapk_installer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698