Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/foozzie/v8_suppressions.py

Issue 2632153002: [foozzie] Remove suppressions for fixed bugs (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/foozzie/v8_suppressions.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_suppressions.py
diff --git a/tools/foozzie/v8_suppressions.py b/tools/foozzie/v8_suppressions.py
index f0f2c64a59d90592c88cb4e6630126f0b7e3028a..66128e07b3f8611afbc5d76bc745b002c860b551 100644
--- a/tools/foozzie/v8_suppressions.py
+++ b/tools/foozzie/v8_suppressions.py
@@ -49,18 +49,15 @@ IGNORE_SOURCES = {
# Ignore by test case pattern. Map from bug->regexp.
# Regular expressions are assumed to be compiled. We use regexp.match.
+# Make sure the code doesn't match in the preamble portion of the test case
+# (i.e. in the modified inlined mjsunit.js). You can reference the comment
+# between the two parts like so:
+# 'crbug.com/666308':
+# re.compile(r'.*End stripped down and modified version.*'
+# r'\.prototype.*instanceof.*.*', re.S)
+# TODO(machenbach): Insert a JS sentinel between the two parts, because
+# comments are stripped during minimization.
IGNORE_TEST_CASES = {
- 'crbug.com/662907':
- re.compile(r'.*new Array.*\[\d+\] =.*'
- r'((Array)|(Object)).prototype.__defineSetter__.*', re.S),
-
- 'crbug.com/663340':
- re.compile(r'.*\.shift\(\).*', re.S),
-
- 'crbug.com/666308':
- re.compile(r'.*End stripped down and modified version.*'
- r'\.prototype.*instanceof.*.*', re.S),
-
'crbug.com/679957':
re.compile(r'.*performance\.now.*', re.S),
}
@@ -77,9 +74,6 @@ IGNORE_OUTPUT = {
'': {
'crbug.com/664068':
re.compile(r'RangeError', re.S),
-
- 'crbug.com/669017':
- re.compile(r'SyntaxError', re.S),
},
'validate_asm': {
'validate_asm':
@@ -110,9 +104,6 @@ ALLOWED_LINE_DIFFS = [
r'^.* is not a function(.*)$',
r'^(.*) is not a .*$',
- # crbug.com/669017
- r'^(.*)SyntaxError: .*$',
-
# Ignore lines of stack traces as character positions might not match.
r'^ at (?:new )?([^:]*):\d+:\d+(.*)$',
r'^(.*):\d+:(.*)$',
« no previous file with comments | « tools/foozzie/v8_suppressions.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698