Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 263213008: Arm64: Fix check errors on Arm64 debug after r21177. (Closed)

Created:
6 years, 7 months ago by rmcilroy
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Arm64: Fix check errors on Arm64 debug after r21177. r21177 added extra AssertStackConsistency() checks which increased code size on debug and caused the assembler buffer to be too large. Increased some of these buffers to compensate. Also, ProfileEntryHoolStub could use the wrong number of instructions for kProfileEntryHookCallSize depending upon whether debug code was being emitted or ALWAYS_ALIGN_CSP was enabled. Fixed this by taking ALWAYS_ALIGN_CSP into account and ensuring that no debug code is emitted during MaybeCallEntryHook(). TBR=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M src/arm64/code-stubs-arm64.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M src/builtins.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rmcilroy
TBRing this to hopefully green up the tree - please let me know if you ...
6 years, 7 months ago (2014-05-06 19:05:14 UTC) #1
rmcilroy
6 years, 7 months ago (2014-05-06 19:07:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r21179 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698