Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2632123008: Try to make named_pipe_script_test less flaky (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M tests/standalone/io/named_pipe_script_test.dart View 1 chunk +36 lines, -12 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-17 23:32:41 UTC) #2
Cutch
LGTM w/c https://codereview.chromium.org/2632123008/diff/1/tests/standalone/io/named_pipe_script_test.dart File tests/standalone/io/named_pipe_script_test.dart (right): https://codereview.chromium.org/2632123008/diff/1/tests/standalone/io/named_pipe_script_test.dart#newcode26 tests/standalone/io/named_pipe_script_test.dart:26: print("Couldn't find $stdinPipePath."); A think /dev/fd/0 is ...
3 years, 11 months ago (2017-01-17 23:37:19 UTC) #3
zra
https://codereview.chromium.org/2632123008/diff/1/tests/standalone/io/named_pipe_script_test.dart File tests/standalone/io/named_pipe_script_test.dart (right): https://codereview.chromium.org/2632123008/diff/1/tests/standalone/io/named_pipe_script_test.dart#newcode26 tests/standalone/io/named_pipe_script_test.dart:26: print("Couldn't find $stdinPipePath."); On 2017/01/17 23:37:19, Cutch wrote: > ...
3 years, 11 months ago (2017-01-17 23:44:31 UTC) #4
zra
3 years, 11 months ago (2017-01-17 23:51:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d956bfe9eb52e187a9794af6119b38bf019df13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698