Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc

Issue 2632123006: Reland: [Parse] ParseInfo owns the parsing Zone. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc ('k') | tools/parser-shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc
diff --git a/test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc b/test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc
index 97c117d7440b204fb921f209a64377980a3e86cc..7bb5bcebdaf25a0dbd81764719b8640e2112df2d 100644
--- a/test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc
+++ b/test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc
@@ -12,7 +12,6 @@
#include "src/isolate.h"
#include "src/objects-inl.h"
#include "src/parsing/parse-info.h"
-#include "src/zone/zone.h"
#include "test/unittests/compiler-dispatcher/compiler-dispatcher-helper.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -29,8 +28,7 @@ class BlockingCompilationJob : public CompilationJob {
BlockingCompilationJob(Isolate* isolate, Handle<JSFunction> function)
: CompilationJob(isolate, &info_, "BlockingCompilationJob",
State::kReadyToExecute),
- zone_(isolate->allocator(), ZONE_NAME),
- parse_info_(&zone_, handle(function->shared())),
+ parse_info_(handle(function->shared())),
info_(&parse_info_, function),
blocking_(false),
semaphore_(0) {}
@@ -55,7 +53,6 @@ class BlockingCompilationJob : public CompilationJob {
Status FinalizeJobImpl() override { return SUCCEEDED; }
private:
- Zone zone_;
ParseInfo parse_info_;
CompilationInfo info_;
base::AtomicValue<bool> blocking_;
« no previous file with comments | « test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc ('k') | tools/parser-shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698