Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc

Issue 2632123006: Reland: [Parse] ParseInfo owns the parsing Zone. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
diff --git a/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc b/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
index 8c250e61e2f8dd9f61d1c4c8e1f3e2bce46d9abe..8301490822b7a6d610fcfc2302767324ecd361aa 100644
--- a/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
+++ b/test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
@@ -815,8 +815,7 @@ TEST_F(CompilerDispatcherTest, EnqueueParsed) {
Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
- Zone zone(i_isolate()->allocator(), ZONE_NAME);
- ParseInfo parse_info(&zone, shared);
+ ParseInfo parse_info(shared);
ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
@@ -841,8 +840,7 @@ TEST_F(CompilerDispatcherTest, EnqueueAndStepParsed) {
Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
- Zone zone(i_isolate()->allocator(), ZONE_NAME);
- ParseInfo parse_info(&zone, shared);
+ ParseInfo parse_info(shared);
ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
ASSERT_FALSE(dispatcher.IsEnqueued(shared));
@@ -878,8 +876,7 @@ TEST_F(CompilerDispatcherTest, FinishAllNow) {
ASSERT_FALSE(shared2->is_compiled());
// Enqueue shared1 as already parsed.
- Zone zone(i_isolate()->allocator(), ZONE_NAME);
- ParseInfo parse_info(&zone, shared1);
+ ParseInfo parse_info(shared1);
ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
ASSERT_TRUE(dispatcher.Enqueue(shared1, parse_info.literal()));

Powered by Google App Engine
This is Rietveld 408576698