Media Remoting: UMAs to track session events and measurements.

media/remoting/remote_renderer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/remoting/remote_renderer_impl.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "media/base/pipeline_status.h"
@@ skipping 270 matching lines @@
   }
   int ReceivedRpcMessageCount() const { return received_rpc_.size(); }
   void ResetReceivedRpcMessage() { received_rpc_.clear(); }
 
   void ValidateCurrentTime(base::TimeDelta current,
                            base::TimeDelta current_max) const {
     ASSERT_EQ(remote_renderer_impl_->current_media_time_, current);
     ASSERT_EQ(remote_renderer_impl_->current_max_time_, current_max);
   }
 
+  base::MessageLoop message_loop_;
   std::unique_ptr<RemotingRendererController> remoting_renderer_controller_;
   std::unique_ptr<RendererClientImpl> render_client_;
   std::unique_ptr<FakeRemotingDemuxerStreamProvider> demuxer_stream_provider_;
   std::unique_ptr<RemoteRendererImpl> remote_renderer_impl_;
-  base::MessageLoop message_loop_;
 
   // RPC handles.
   const int receiver_renderer_handle_;
   const int receiver_audio_demuxer_callback_handle_;
   const int receiver_video_demuxer_callback_handle_;
   int sender_client_handle_;
   int sender_renderer_callback_handle_;
   int sender_audio_demuxer_handle_;
   int sender_video_demuxer_handle_;
 
@@ skipping 52 matching lines @@
   RunPendingTasks();
 
   // Checks if it sends out RPC message with correct value.
   ASSERT_EQ(1, ReceivedRpcMessageCount());
   const remoting::pb::RpcMessage* rpc =
       PeekRpcMessage(remoting::pb::RpcMessage::RPC_R_STARTPLAYINGFROM);
   ASSERT_TRUE(rpc);
   ASSERT_EQ(rpc->integer64_value(), 100);
 }
 
-// SetVolume can be called anytime without conditions.
 TEST_F(RemoteRendererImplTest, SetVolume) {
+  // Initialize Renderer because, as of this writing, the pipeline guarantees it
+  // will not call SetVolume() until after the media::Renderer is initialized.
+  InitializeRenderer();
+  RunPendingTasks();
+  ASSERT_EQ(0, ReceivedRpcMessageCount());
+
   // SetVolume() will send remoting::pb::RpcMessage::RPC_R_SETVOLUME RPC.
   remote_renderer_impl_->SetVolume(3.0);
   RunPendingTasks();
 
   // Checks if it sends out RPC message with correct value.
   ASSERT_EQ(1, ReceivedRpcMessageCount());
   const remoting::pb::RpcMessage* rpc =
       PeekRpcMessage(remoting::pb::RpcMessage::RPC_R_SETVOLUME);
   ASSERT_TRUE(rpc);
   ASSERT_TRUE(rpc->double_value() == 3.0);
 }
 
-// SetVolume can be called only when the state is playing.
 TEST_F(RemoteRendererImplTest, SetPlaybackRate) {
-  // Without initializing renderer, SetPlaybackRate() will be no-op.
-  remote_renderer_impl_->SetPlaybackRate(-1.5);
+  // Initialize Renderer because, as of this writing, the pipeline guarantees it
+  // will not call SetPlaybackRate() until after the media::Renderer is
+  // initialized.
+  InitializeRenderer();
   RunPendingTasks();
   ASSERT_EQ(0, ReceivedRpcMessageCount());
 
-  // Initialize Renderer
-  InitializeRenderer();
-  RunPendingTasks();
-
   remoting_renderer_controller_->GetRpcBroker()->SetMessageCallbackForTesting(
       base::Bind(&RemoteRendererImplTest::OnSendMessageToSink,
                  base::Unretained(this)));
   remote_renderer_impl_->SetPlaybackRate(2.5);
   RunPendingTasks();
   ASSERT_EQ(1, ReceivedRpcMessageCount());
   // Checks if it sends out RPC message with correct value.
   const remoting::pb::RpcMessage* rpc =
       PeekRpcMessage(remoting::pb::RpcMessage::RPC_R_SETPLAYBACKRATE);
   ASSERT_TRUE(rpc);
@@ skipping 149 matching lines @@
   InitializeRenderer();
   // Issues RPC_RC_ONDURATIONCHANGE RPC message.
   EXPECT_CALL(*render_client_, OnDurationChange(_)).Times(0);
   std::unique_ptr<remoting::pb::RpcMessage> rpc(new remoting::pb::RpcMessage());
   rpc->set_handle(5);
   rpc->set_proc(remoting::pb::RpcMessage::RPC_RC_ONDURATIONCHANGE);
   rpc->set_integer64_value(-345);
   OnReceivedRpc(std::move(rpc));
   RunPendingTasks();
 }
+
+// TODO(xjz): Tests for detecting PACING_TOO_SLOWLY and FRAME_DROP_RATE_HIGH.
+
 }  // namespace media