Adding status info to DownloadUIItem and piping it through.

chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index af41f9493f65d44ca74fb38ddb03a914282e6cff..bea20a92e77b9d93328c4a6caa14c35f17b5e523 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -42,11 +42,42 @@ using base::android::JavaParamRef;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 
+namespace {
+const char kDownloadUIAdapterKey[] = "download-ui-adapter";
+}
+
 namespace offline_pages {
 namespace android {
 
 namespace {
 
+class DownloadUIAdapterDelegate : public DownloadUIAdapter::Delegate {
+ public:
+  explicit DownloadUIAdapterDelegate(OfflinePageModel* model);
+
+  // DownloadUIAdapter::Delegate
+  bool IsVisibleInUI(const ClientId& client_id) override;
+  bool IsTemporaryHiddenInUI(const ClientId& client_id) override;
+
+ private:
+  // Not owned, cached service pointer.
+  OfflinePageModel* model_;
+};
+
+DownloadUIAdapterDelegate::DownloadUIAdapterDelegate(OfflinePageModel* model)
+    : model_(model) {}
+
+bool DownloadUIAdapterDelegate::IsVisibleInUI(const ClientId& client_id) {
+  const std::string& name_space = client_id.name_space;
+  return model_->GetPolicyController()->IsSupportedByDownload(name_space) &&
+         base::IsValidGUID(client_id.id);
+}
+
+bool DownloadUIAdapterDelegate::IsTemporaryHiddenInUI(
+    const ClientId& client_id) {
+  return false;
+}
+
 // TODO(dewittj): Move to Download UI Adapter.
 content::WebContents* GetWebContentsFromJavaTab(
     const ScopedJavaGlobalRef<jobject>& j_tab_ref) {
@@ -185,7 +216,8 @@ void ToJavaOfflinePageDownloadItemList(
   for (const auto item : items) {
     Java_OfflinePageDownloadBridge_createDownloadItemAndAddToList(
         env, j_result_obj, ConvertUTF8ToJavaString(env, item->guid),
-        ConvertUTF8ToJavaString(env, item->url.spec()),
+        ConvertUTF8ToJavaString(env, item->url.spec()), item->download_state,
+        item->download_progress.current, item->download_progress.max,

[dewittj, 2017/02/03 22:05:40]

hm, this doesn't seem to match DownloadUIItem

[Dmitry Titov, 2017/02/08 00:45:08]

Done.

         ConvertUTF16ToJavaString(env, item->title),
         ConvertUTF8ToJavaString(env, item->target_path.value()),
         item->start_time.ToJavaTime(), item->total_bytes);
@@ -197,7 +229,8 @@ ScopedJavaLocalRef<jobject> ToJavaOfflinePageDownloadItem(
     const DownloadUIItem& item) {
   return Java_OfflinePageDownloadBridge_createDownloadItem(
       env, ConvertUTF8ToJavaString(env, item.guid),
-      ConvertUTF8ToJavaString(env, item.url.spec()),
+      ConvertUTF8ToJavaString(env, item.url.spec()), item.download_state,
+      item.download_progress.current, item.download_progress.max,
       ConvertUTF16ToJavaString(env, item.title),
       ConvertUTF8ToJavaString(env, item.target_path.value()),
       item.start_time.ToJavaTime(), item.total_bytes);
@@ -442,8 +475,17 @@ static jlong Init(JNIEnv* env,
   OfflinePageModel* offline_page_model =
       OfflinePageModelFactory::GetForBrowserContext(browser_context);

[dewittj, 2017/01/30 20:59:34]

do we need to |nullptr|-check here

[Dmitry Titov, 2017/02/08 00:45:08]

Not sure what would be a great action here if there is no model at this point.
It doesn't introduce new crashes since this is exactly moved from
DownloadUIAdapter::FromOfflinePageModel, so the code path is equivalent.

On the other hand, I don't think we need to support (and have code) for creating
bridges for incognito... and define how they should behave. Crash is fine in
this case. Added DCHECK.

 
-  DownloadUIAdapter* adapter =
-      DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
+  DownloadUIAdapter* adapter = static_cast<DownloadUIAdapter*>(
+      offline_page_model->GetUserData(kDownloadUIAdapterKey));
+
+  if (!adapter) {
+    RequestCoordinator* request_coordinator =
+        RequestCoordinatorFactory::GetForBrowserContext(browser_context);

[dewittj, 2017/01/30 20:59:34]

also do we need to nullptr-check here

[Dmitry Titov, 2017/02/08 00:45:08]

Ditto as above.

+    adapter = new DownloadUIAdapter(
+        offline_page_model, request_coordinator,
+        base::MakeUnique<DownloadUIAdapterDelegate>(offline_page_model));
+    offline_page_model->SetUserData(kDownloadUIAdapterKey, adapter);
+  }
 
   return reinterpret_cast<jlong>(
       new OfflinePageDownloadBridge(env, obj, adapter, browser_context));