Issue 2631893002: Revert "Support spawnUri in app snapshots."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2631893002: Revert "Support spawnUri in app snapshots." (Closed)

Created:
3 years, 11 months ago by rmacnak

Modified:
3 years, 11 months ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Support spawnUri in app snapshots." Failures on IA32. This reverts commit c6ecfe1746137751e4b0fce9edcdf63a3aa93e12. Committed: https://github.com/dart-lang/sdk/commit/12a3699301b9efd176846c6d9d2daabb550c64eb

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -88 lines)			Patch
M	runtime/bin/main.cc	View	12 chunks	+16 lines, -56 lines	0 comments	Download
M	runtime/bin/snapshot_empty.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/snapshot_in.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/observatory/tests/service/service.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/benchmark_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/isolate_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/metrics_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/zone_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/application_snapshot.gni	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	utils/pub/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

rmacnak

3 years, 11 months ago (2017-01-13 23:52:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12a3699301b9efd176846c6d9d2daabb550c64eb (presubmit successful).