Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: chrome/browser/resources/settings/controls/settings_input.js

Issue 2631863002: MD Settings: Use "change" event instead of "blur" for settings-input. (Closed)
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_input.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_input.js
diff --git a/chrome/browser/resources/settings/controls/settings_input.js b/chrome/browser/resources/settings/controls/settings_input.js
index 012a8bcaeccb646c238874c19da2cf913ad8e84c..2652db1763bc0829117c9cedc4143789843170b0 100644
--- a/chrome/browser/resources/settings/controls/settings_input.js
+++ b/chrome/browser/resources/settings/controls/settings_input.js
@@ -90,10 +90,11 @@ Polymer({
},
/**
- * Blur method for paper-input. Only update the pref value on a blur event.
+ * Change event handler for paper-input. Updates the pref value.
+ * settings-input uses the change event because it is fired by the Enter key.
* @private
*/
- onBlur_: function() {
+ onChange_: function() {
if (!this.pref)
return;
« no previous file with comments | « chrome/browser/resources/settings/controls/settings_input.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698