Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2631853002: Give OOPIF FrameViews their own scroll animation timelines and hosts (Closed)
Patch Set: Attempt to fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 7e1d2c3d94fe15ea2b7235f99dde0f3d274f82f8..ef30de3ab41f025199562a739f7fde2de55bd984 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -395,7 +395,12 @@ void WebPagePopupImpl::setIsAcceleratedCompositingActive(bool enter) {
m_isAcceleratedCompositingActive = true;
m_animationHost = WTF::makeUnique<CompositorAnimationHost>(
m_layerTreeView->compositorAnimationHost());
- m_page->layerTreeViewInitialized(*m_layerTreeView);
+ m_page->layerTreeViewInitialized(*m_layerTreeView,
+ m_popupClient->ownerElement()
+ .document()
+ .frame()
+ ->localFrameRoot()
+ ->view());
} else {
m_isAcceleratedCompositingActive = false;
m_animationHost = nullptr;
@@ -412,8 +417,14 @@ void WebPagePopupImpl::beginFrame(double lastFrameTimeMonotonic) {
}
void WebPagePopupImpl::willCloseLayerTreeView() {
- if (m_page && m_layerTreeView)
- m_page->willCloseLayerTreeView(*m_layerTreeView);
+ if (m_page && m_layerTreeView) {
+ m_page->willCloseLayerTreeView(*m_layerTreeView,
+ m_popupClient->ownerElement()
+ .document()
+ .frame()
+ ->localFrameRoot()
+ ->view());
+ }
setIsAcceleratedCompositingActive(false);
m_layerTreeView = nullptr;

Powered by Google App Engine
This is Rietveld 408576698