third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h - Issue 2631853002: Give OOPIF FrameViews their own scroll animation timelines and hosts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2631853002: Give OOPIF FrameViews their own scroll animation timelines and hosts (Closed)

Patch Set: Fixes from bokan comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

index 7d97eb4cf52feb131f0b7b11c6b0eb2fd57f0970..c70717de3976c24021bd229f6e506f75396cd8fc 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -61,8 +61,12 @@ class CORE_EXPORT ScrollingCoordinator final

~ScrollingCoordinator();

DECLARE_TRACE();

- void layerTreeViewInitialized(WebLayerTreeView&);

- void willCloseLayerTreeView(WebLayerTreeView&);

+ // The FrameView argument is optional, nullptr causes the the scrolling

+ // animation host and timeline to be owned by the ScrollingCoordinator. When

+ // not null, the host and timeline are attached to the specified FrameView.

+ // A FrameView only needs to own them when it is the view for an OOPIF.

+ void layerTreeViewInitialized(WebLayerTreeView&, FrameView*);

+ void willCloseLayerTreeView(WebLayerTreeView&, FrameView*);

void willBeDestroyed();