third_party/WebKit/LayoutTests/http/tests/misc/resources/cross-origin-subframe-for-scrolling.html - Issue 2631853002: Give OOPIF FrameViews their own scroll animation timelines and hosts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/misc/resources/cross-origin-subframe-for-scrolling.html

Issue 2631853002: Give OOPIF FrameViews their own scroll animation timelines and hosts (Closed)

Patch Set: Test added Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes.html » ('j') | third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/js-test-resources/js-test.js"></script>
	bokan 2017/01/19 20:05:39 Why do you need js-test here? IIRC, window.testRun Why do you need js-test here? IIRC, window.testRunner had a flag you could use to turn on async tests. Also, testharness.js is now encouraged for writing layout tests. kenrb 2017/01/19 21:36:19 I realized that after I had already written it thi Show quoted text On 2017/01/19 20:05:39, bokan wrote: > Why do you need js-test here? IIRC, window.testRunner had a flag you could use > to turn on async tests. > > Also, testharness.js is now encouraged for writing layout tests. I realized that after I had already written it this way. Will change.
	3 <div style="height: 300px"></div>

	4

	5 <script>

	6 setPrintTestResultsLazily();

	7 self.jsTestIsAsync = true;

	8

	9 window.onload = (() => {

	10 if (!window.eventSender \|\| !window.internals) {

	11 debug("This test requires window.eventSender.");

	12 return;

	13 }

	14 internals.settings.setScrollAnimatorEnabled(true);

	15 });

	16

	17 function handleMessage(event) {

	18 if (event.data.hasOwnProperty('scrollBy')) {

	19 eventSender.mouseMoveTo(event.data.left + 5, event.data.top + 5);
	bokan 2017/01/19 20:05:39 Does event sender perform the scroll event in the Does event sender perform the scroll event in the renderer form which it's called (and that's why you can't perform these mouse events from the top frame?). kenrb 2017/01/19 21:36:19 Yes, we don't have a way to send events across pro Show quoted text On 2017/01/19 20:05:39, bokan wrote: > Does event sender perform the scroll event in the renderer form which it's > called (and that's why you can't perform these mouse events from the top > frame?). Yes, we don't have a way to send events across processes in layout tests at this point.
	20 eventSender.mouseScrollBy(0, event.data.scrollBy);

	21 requestAnimationFrame(() => {setTimeout(() => {event.source.postMessage("", "*")}, 500)});
	bokan 2017/01/19 20:05:39 I'm weary of timeouts, they're a frequent source o I'm weary of timeouts, they're a frequent source of flakiness. Could we put the postMessage in an onScroll handler and have the test simply check that scrollTop > 0? kenrb 2017/01/19 21:36:19 Will update in follow up. Show quoted text On 2017/01/19 20:05:39, bokan wrote: > I'm weary of timeouts, they're a frequent source of flakiness. Could we put the > postMessage in an onScroll handler and have the test simply check that scrollTop > > 0? Will update in follow up.
	22 } else {

	23 event.source.postMessage({scrollTop: document.documentElement.scrollTop}, "* ");

	24 }

	25 }

	26

	27 window.addEventListener("message", handleMessage);

	28 </script>

OLD	NEW