Give OOPIF FrameViews their own scroll animation timelines and hosts

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 633 matching lines @@
       NOTIMPLEMENTED();
       break;
   }
 }
 
 bool WebFrameWidgetImpl::isAcceleratedCompositingActive() const {
   return m_isAcceleratedCompositingActive;
 }
 
 void WebFrameWidgetImpl::willCloseLayerTreeView() {
-  if (m_layerTreeView)
-    page()->willCloseLayerTreeView(*m_layerTreeView);
+  if (m_layerTreeView) {
+    page()->willCloseLayerTreeView(*m_layerTreeView,
+                                   m_localRoot->frame()->view());
+  }
 
   setIsAcceleratedCompositingActive(false);
   m_mutator = nullptr;
   m_layerTreeView = nullptr;
   m_animationHost = nullptr;
   m_layerTreeViewClosed = true;
 }
 
 void WebFrameWidgetImpl::didAcquirePointerLock() {
   page()->pointerLockController().didAcquirePointerLock();
@@ skipping 323 matching lines @@
     if (m_layerTreeView && m_layerTreeView->compositorAnimationHost()) {
       m_animationHost = WTF::makeUnique<CompositorAnimationHost>(
           m_layerTreeView->compositorAnimationHost());
     }
   }
 
   if (WebDevToolsAgentImpl* devTools = m_localRoot->devToolsAgentImpl())
     devTools->layerTreeViewChanged(m_layerTreeView);
 
   page()->settings().setAcceleratedCompositingEnabled(m_layerTreeView);
-  if (m_layerTreeView)
-    page()->layerTreeViewInitialized(*m_layerTreeView);
+  if (m_layerTreeView) {
+    LOG(ERROR) << "WFWI::initializeLayerTreeView(), this = " << (void*)this

[bokan, 2017/01/17 20:40:16]

Is this logging leftover from debugging?

[kenrb, 2017/01/19 19:07:40]

Yes, sorry, removed.

[bokan, 2017/01/19 20:05:39]

Acknowledged.

+               << ", root frame view = " << (void*)m_localRoot->frame()->view();
+    page()->layerTreeViewInitialized(*m_layerTreeView,
+                                     m_localRoot->frame()->view());
+  }
 
   // FIXME: only unittests, click to play, Android priting, and printing (for
   // headers and footers) make this assert necessary. We should make them not
   // hit this code and then delete allowsBrokenNullLayerTreeView.
   DCHECK(m_layerTreeView || !m_client ||
          m_client->allowsBrokenNullLayerTreeView());
 }
 
 void WebFrameWidgetImpl::setIsAcceleratedCompositingActive(bool active) {
   // In the middle of shutting down; don't try to spin back up a compositor.
@@ skipping 121 matching lines @@
   return nullptr;
 }
 
 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const {
   if (!m_imeAcceptEvents)
     return nullptr;
   return focusedLocalFrameInWidget();
 }
 
 }  // namespace blink