Give OOPIF FrameViews their own scroll animation timelines and hosts

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
  * reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@gmail.com>
@@ skipping 1864 matching lines @@
   return box().frame()->view();
 }
 
 void PaintLayerScrollableArea::resetRebuildScrollbarLayerFlags() {
   m_rebuildHorizontalScrollbarLayer = false;
   m_rebuildVerticalScrollbarLayer = false;
 }
 
 CompositorAnimationHost* PaintLayerScrollableArea::compositorAnimationHost()
     const {
-  if (ScrollingCoordinator* coordinator = getScrollingCoordinator())
-    return coordinator->compositorAnimationHost();
-
-  return nullptr;
+  return m_layer.layoutObject()->frameView()->compositorAnimationHost();

[bokan, 2017/01/17 20:40:16]

VisualViewport also calls this via ScrollingCoordinator but I forget how
VisualViewport works with OOPIF, does just the top level renderer have one? Or
do we just rely on OOP renderers never calling into their own instances of it?

[kenrb, 2017/01/19 19:07:40]

There are VisualViewports in OOPIF processes, but they mostly do nothing. I
think we store the root viewport size in it because of cases where a remote main
frame gets swapped to a local main frame, but that's it.

[bokan, 2017/01/19 20:05:39]

Ok, in that case, if it works please add DCHECKs inside
VisualViewport::compositorAnimationHost and compositorAnimationTimeline that
ensure we never call those from an OOPIF

[kenrb, 2017/01/19 21:36:19]

I will do this in a follow up CL.

 }
 
 CompositorAnimationTimeline*
 PaintLayerScrollableArea::compositorAnimationTimeline() const {
-  if (ScrollingCoordinator* coordinator = getScrollingCoordinator())
-    return coordinator->compositorAnimationTimeline();
-
-  return nullptr;
+  return m_layer.layoutObject()->frameView()->compositorAnimationTimeline();
 }
 
 PaintLayerScrollableArea*
 PaintLayerScrollableArea::ScrollbarManager::scrollableArea() {
   return toPaintLayerScrollableArea(m_scrollableArea.get());
 }
 
 void PaintLayerScrollableArea::ScrollbarManager::destroyDetachedScrollbars() {
   DCHECK(!m_hBarIsAttached || m_hBar);
   DCHECK(!m_vBarIsAttached || m_vBar);
@@ skipping 198 matching lines @@
 
 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
     clampScrollableAreas() {
   for (auto& scrollableArea : *s_needsClamp)
     scrollableArea->clampScrollOffsetAfterOverflowChange();
   delete s_needsClamp;
   s_needsClamp = nullptr;
 }
 
 }  // namespace blink