Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxfa/app/cxfa_pieceline.h

Issue 2631703003: Avoid endless loop deleting CFGAS_GEFont. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fgas/font/cfgas_gefont.cpp ('k') | xfa/fxfa/app/cxfa_pieceline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/app/cxfa_pieceline.h
diff --git a/xfa/fxfa/app/cxfa_pieceline.h b/xfa/fxfa/app/cxfa_pieceline.h
index 48dfdae04d7555194ed793622458e3bb33cb630f..3e6bb99876a66bfaa40eee12d9505b8743fb8c17 100644
--- a/xfa/fxfa/app/cxfa_pieceline.h
+++ b/xfa/fxfa/app/cxfa_pieceline.h
@@ -7,6 +7,9 @@
#ifndef XFA_FXFA_APP_CXFA_PIECELINE_H_
#define XFA_FXFA_APP_CXFA_PIECELINE_H_
+#include <memory>
+#include <vector>
+
#include "core/fxcrt/fx_basic.h"
class XFA_TextPiece;
@@ -16,7 +19,7 @@ class CXFA_PieceLine {
CXFA_PieceLine();
~CXFA_PieceLine();
- CFX_ArrayTemplate<XFA_TextPiece*> m_textPieces;
+ std::vector<std::unique_ptr<XFA_TextPiece>> m_textPieces;
CFX_ArrayTemplate<int32_t> m_charCounts;
};
« no previous file with comments | « xfa/fgas/font/cfgas_gefont.cpp ('k') | xfa/fxfa/app/cxfa_pieceline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698