xfa/fde/cfde_txtedtengine.cpp - Issue 2631703003: Avoid endless loop deleting CFGAS_GEFont.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/cfde_txtedtengine.cpp

Issue 2631703003: Avoid endless loop deleting CFGAS_GEFont. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fde/cfde_txtedtengine.cpp

diff --git a/xfa/fde/cfde_txtedtengine.cpp b/xfa/fde/cfde_txtedtengine.cpp

index 8bb944712a0afcdd2bcf8b0c865e8500c7b9adc1..7ef6b3ff06771c6c0d2e2010daf780b3b89e985f 100644

--- a/xfa/fde/cfde_txtedtengine.cpp

+++ b/xfa/fde/cfde_txtedtengine.cpp

@@ -84,7 +84,7 @@ void CFDE_TxtEdtEngine::SetEditParams(const FDE_TXTEDTPARAMS& params) {

if (!m_pTextBreak)

m_pTextBreak = pdfium::MakeUnique<CFX_TxtBreak>(FX_TXTBREAKPOLICY_None);

- FXSYS_memcpy(&m_Param, &params, sizeof(FDE_TXTEDTPARAMS));

+ m_Param = params;

m_wLineEnd = params.wLineBreakChar;

m_bAutoLineEnd = (m_Param.nLineEnd == FDE_TXTEDIT_LINEEND_Auto);

UpdateTxtBreak();

« no previous file with comments | « core/fxcrt/cfx_retain_ptr.h ('k') | xfa/fgas/font/cfgas_gefont.h » ('j') | no next file with comments »