Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 26317009: Move v8_optimized_debug default value to standalone.gypi (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move v8_optimized_debug default value to standalone.gypi This is so that Chromium can have its own overridable default value without colliding with ours. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M build/standalone.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
M build/toolchain.gypi View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
As discussed.
7 years, 2 months ago (2013-10-14 11:47:12 UTC) #1
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-10-14 12:57:55 UTC) #2
Jakob Kummerow
7 years, 2 months ago (2013-10-14 13:07:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698