tools/metrics/histograms/histograms.xml - Issue 2631633003: [Video] Only start tracking foreground time if the video was resumed.

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2631633003: [Video] Only start tracking foreground time if the video was resumed. (Closed)

Patch Set: Split the histogram into paused and disabled track Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 09d1568867fddb96c9060b75e995b25950d366a2..8e39a45a8356c535019e19c2762fb2db83583ffd 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -26204,12 +26204,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="Media.Video.TimeFromForegroundToFirstFrame" units="ms">

+<histogram name="Media.Video.TimeFromForegroundToFirstFrame.DisabledTrack"

DaleCurtis 2017/01/18 23:39:02 Can't drop histograms like this. Need to mark the

Ilya Sherman 2017/01/19 02:03:39 +1

whywhat 2017/01/19 02:33:58 Done.

+ units="ms">

+ <owner>avayvod@chromium.org</owner>

+ <owner>dalecurtis@chromium.org</owner>

+ <summary>

+ Records the time between the moment when the video element that was or could

+ have video track disabled in the background is brought to the foreground and

+ when the video frame compositor outputs the next frame.

+ </summary>

+</histogram>

+<histogram name="Media.Video.TimeFromForegroundToFirstFrame.Paused" units="ms">

<owner>avayvod@chromium.org</owner>

<owner>dalecurtis@chromium.org</owner>

- Records the time between the moment when the video element is brought to the

- foreground and when the video frame compositor outputs the next frame.

+ Records the time between the moment when the video element that was or could

+ be paused in the background is brought to the foreground and when the video

Ilya Sherman 2017/01/19 02:03:39 What does "or could be" in this histogram descript

whywhat 2017/01/19 02:33:58 It will only be paused if the feature flag is set,

Ilya Sherman 2017/01/19 02:39:57 Ah, I see. Could you please clarify that in the h

whywhat 2017/01/19 03:23:12 Done. Let me know if I could use better wording.

+ frame compositor outputs the next frame.

</summary>

</histogram>