Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: Source/bindings/v8/ScriptPromiseResolverWithContext.h

Issue 263163006: Fix crash when ExecutionContext is torn down before a crypto operation has completed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix comment typo Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptPromiseResolverWithContext.h
diff --git a/Source/bindings/v8/ScriptPromiseResolverWithContext.h b/Source/bindings/v8/ScriptPromiseResolverWithContext.h
index e31854b380f4487007433871999c6ea6ff884a21..1bcef1730facbf35e452eec872a5ec44bb76012b 100644
--- a/Source/bindings/v8/ScriptPromiseResolverWithContext.h
+++ b/Source/bindings/v8/ScriptPromiseResolverWithContext.h
@@ -27,7 +27,7 @@ namespace WebCore {
// ExecutionContext state. When the ExecutionContext is suspended,
// resolve or reject will be delayed. When it is stopped, resolve or reject
// will be ignored.
-class ScriptPromiseResolverWithContext FINAL : public ActiveDOMObject, public RefCounted<ScriptPromiseResolverWithContext> {
+class ScriptPromiseResolverWithContext : public ActiveDOMObject, public RefCounted<ScriptPromiseResolverWithContext> {
WTF_MAKE_NONCOPYABLE(ScriptPromiseResolverWithContext);
public:
@@ -74,6 +74,9 @@ public:
return scriptState->context()->Global();
}
+protected:
+ explicit ScriptPromiseResolverWithContext(ScriptState*);
+
private:
enum ResolutionState {
Pending,
@@ -82,8 +85,6 @@ private:
ResolvedOrRejected,
};
- explicit ScriptPromiseResolverWithContext(ScriptState*);
-
template<typename T>
v8::Handle<v8::Value> toV8Value(const T& value)
{
« no previous file with comments | « LayoutTests/crypto/resources/worker-infinite-loop-generateKey.js ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698