Add Fasta tests.

Add Fasta tests.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/789336cb2994a67b3b5c4f8826fc36787f9f4bec

[ahe, 2017-01-13 12:13:34]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-01-16 08:43:12]

lgtm

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
File pkg/fasta/lib/testing/kernel_chain.dart (right):

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:130: String vmPath = await
getEnvironmentVariable("DART_AOT_VM", Environment.file,
Long line.

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:236: const MatchExpectation(this.suffix,
{this.updateExpectations: true});
Weird default value given the class name.

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:242: (Library library)
=>library.importUri.scheme != "dart");
`=>library` -> `=> library`

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:372: "diff", <String>["-u",
expected.toFilePath(), "-"], input: actual);
This probably doesn't work on Windows.

[ahe, 2017-01-16 09:03:03]

Thank you, Johnni!

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
File pkg/fasta/lib/testing/kernel_chain.dart (right):

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:130: String vmPath = await
getEnvironmentVariable("DART_AOT_VM", Environment.file,
On 2017/01/16 08:43:12, Johnni Winther wrote:
> Long line.

Done.

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:236: const MatchExpectation(this.suffix,
{this.updateExpectations: true});
On 2017/01/16 08:43:12, Johnni Winther wrote:
> Weird default value given the class name.

Good point, I've added a todo.

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:242: (Library library)
=>library.importUri.scheme != "dart");
On 2017/01/16 08:43:12, Johnni Winther wrote:
> `=>library` -> `=> library`

Done.

https://codereview.chromium.org/2631613003/diff/1/pkg/fasta/lib/testing/kerne...
pkg/fasta/lib/testing/kernel_chain.dart:372: "diff", <String>["-u",
expected.toFilePath(), "-"], input: actual);
On 2017/01/16 08:43:12, Johnni Winther wrote:
> This probably doesn't work on Windows.

Added todo.

[ahe, 2017-01-16 09:03:58]

Description was changed from

==========
Add Fasta tests.
==========

to

==========
Add Fasta tests.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/789336cb2994a67b3b5c4f8826fc36787f9f4bec
==========

[ahe, 2017-01-16 09:04:00]

Committed patchset #2 (id:20001) manually as
789336cb2994a67b3b5c4f8826fc36787f9f4bec (presubmit successful).