Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial upload Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 447473130fbe7c6859928a664a7689faf669395c..b1f343043958384974438fe18d124c3c81f83429 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -16,6 +16,7 @@
#include "base/process/process.h"
#include "base/values.h"
#include "content/browser/renderer_host/frame_tree.h"
+#include "content/browser/renderer_host/navigator_observer.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/web_contents/navigation_controller_impl.h"
@@ -48,6 +49,7 @@ class InterstitialPageImpl;
class JavaBridgeDispatcherHostManager;
class JavaScriptDialogManager;
class PowerSaveBlocker;
+class RenderFrameHost;
class RenderViewHost;
class RenderViewHostDelegateView;
class RenderViewHostImpl;
@@ -77,7 +79,8 @@ class CONTENT_EXPORT WebContentsImpl
public RenderViewHostDelegate,
public RenderWidgetHostDelegate,
public RenderViewHostManager::Delegate,
- public NotificationObserver {
+ public NotificationObserver,
+ public NavigatorObserver {
public:
virtual ~WebContentsImpl();
@@ -329,12 +332,6 @@ class CONTENT_EXPORT WebContentsImpl
base::TerminationStatus status,
int error_code) OVERRIDE;
virtual void RenderViewDeleted(RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidStartProvisionalLoadForFrame(
- RenderViewHost* render_view_host,
- int64 frame_id,
- int64 parent_frame_id,
- bool main_frame,
- const GURL& url) OVERRIDE;
virtual void DidRedirectProvisionalLoad(
RenderViewHost* render_view_host,
int32 page_id,
@@ -464,6 +461,20 @@ class CONTENT_EXPORT WebContentsImpl
SiteInstance* instance) OVERRIDE;
virtual FrameTree* GetFrameTree() OVERRIDE;
+ // NavigatorObserver --------------------------------------------------------
+ virtual void DidStartProvisionalLoad(
+ int64 frame_id,
+ int64 parent_frame_id,
+ bool is_main_frame,
+ const GURL& validated_url,
+ bool is_error_page,
+ bool is_iframe_srcdoc,
+ RenderFrameHost* render_frame_host) OVERRIDE;
+
+ virtual void ProvisionalChangeToMainFrameUrl(
+ const GURL& url,
+ RenderFrameHost* render_frame_host) OVERRIDE;
+
// RenderWidgetHostDelegate --------------------------------------------------
virtual void RenderWidgetDeleted(
@@ -816,7 +827,7 @@ class CONTENT_EXPORT WebContentsImpl
// Manages creation and swapping of render views.
RenderViewHostManager render_manager_;
- // The frame tree structure of the current page.
+ // The frame tree hierarchy of the current page.
FrameTree frame_tree_;
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698