Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some cleanup. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index dcc506ae294d2ff81fe1c9ddbf01816cc66c8d6c..e382666494d7cacbfa637cc426664a6a266520ae 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -290,12 +290,6 @@ class CONTENT_EXPORT WebContentsImpl
base::TerminationStatus status,
int error_code) OVERRIDE;
virtual void RenderViewDeleted(RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidStartProvisionalLoadForFrame(
- RenderViewHost* render_view_host,
- int64 frame_id,
- int64 parent_frame_id,
- bool main_frame,
- const GURL& url) OVERRIDE;
virtual void DidRedirectProvisionalLoad(
RenderViewHost* render_view_host,
int32 page_id,
@@ -427,6 +421,21 @@ class CONTENT_EXPORT WebContentsImpl
SiteInstance* instance) OVERRIDE;
virtual FrameTree* GetFrameTree() OVERRIDE;
+ // NavigatorDelegate ---------------------------------------------------------
+
+ virtual void DidStartProvisionalLoad(
+ RenderFrameHostImpl* render_frame_host,
+ int64 frame_id,
+ int64 parent_frame_id,
+ bool is_main_frame,
+ const GURL& validated_url,
+ bool is_error_page,
+ bool is_iframe_srcdoc) OVERRIDE;
+
+ virtual void NotifyProvisionalChangeToMainFrameUrl(
+ RenderFrameHostImpl* render_frame_host,
+ const GURL& url) OVERRIDE;
Charlie Reis 2013/11/21 21:59:32 What about NotifyNavigationStateChanged?
nasko 2013/11/22 01:02:34 Done.
+
// RenderWidgetHostDelegate --------------------------------------------------
virtual void RenderWidgetDeleted(

Powered by Google App Engine
This is Rietveld 408576698