Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: content/browser/frame_host/frame_tree_node.h

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some cleanup. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_node.h
diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h
index a110ff9aab557b4155a3781c7374748293dc4373..f53ffbf069cdbb8941e1be13ef492ac480a9349c 100644
--- a/content/browser/frame_host/frame_tree_node.h
+++ b/content/browser/frame_host/frame_tree_node.h
@@ -33,14 +33,20 @@ class CONTENT_EXPORT FrameTreeNode {
RenderWidgetHostDelegate* render_widget_delegate,
RenderViewHostManager::Delegate* manager_delegate,
int64 frame_id,
- const std::string& name,
- scoped_ptr<RenderFrameHostImpl> render_frame_host);
+ const std::string& name);
~FrameTreeNode();
void AddChild(scoped_ptr<FrameTreeNode> child);
void RemoveChild(FrameTreeNode* child);
+ // TODO(nasko): This method should be removed once there is a
+ // RenderFrameHostManager for each node in the frame tree.
+ void set_render_frame_host(
Charlie Reis 2013/11/21 21:59:32 I'm a bit uncomfortable about decoupling this from
nasko 2013/11/22 01:02:34 Yes, we do. Since RFH is created after FTN, until
+ scoped_ptr<RenderFrameHostImpl> render_frame_host) {
+ render_frame_host_ = render_frame_host.release();
+ }
+
// Transitional API allowing the RenderFrameHost of a FrameTreeNode
// representing the main frame to be provided by someone else. After
// this is called, the FrameTreeNode no longer owns its RenderFrameHost.

Powered by Google App Engine
This is Rietveld 408576698