content/browser/frame_host/frame_tree_unittest.cc - Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_unittest.cc

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on Charlie's latest review. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_tree_unittest.cc

diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc

index ebdf3118fcf1bf34eb918518a6f5c2b74f134a69..6f1bb3303805386ad0aa7a5c112fa2960ca39b7d 100644

--- a/content/browser/frame_host/frame_tree_unittest.cc

+++ b/content/browser/frame_host/frame_tree_unittest.cc

@@ -110,6 +110,7 @@ TEST_F(FrameTreeTest, Shape) {

RenderFrameHostFactory::Create(static_cast<RenderViewHostImpl*>(rvh()),

NULL,

&frame_tree,

+ frame_tree.root(),

process()->GetNextRoutingID(),

false);

frame_tree.SwapMainFrame(render_frame_host.get());

@@ -151,7 +152,7 @@ TEST_F(FrameTreeTest, Shape) {

GetTreeState(&frame_tree));

// Test removing of nodes.

- frame_tree.RemoveFrame(555, 655);

+ frame_tree.RemoveFrame(NULL, 555, 655);

ASSERT_EQ("5: [14: [244: [], 245: []], "

"15: [255 'no children node': []], "

"16: [264: [], 265: [], 266: [], "

@@ -159,7 +160,7 @@ TEST_F(FrameTreeTest, Shape) {

"[365: [455: [555: []]]], 268: []]]",

GetTreeState(&frame_tree));

- frame_tree.RemoveFrame(16, 265);

+ frame_tree.RemoveFrame(NULL, 16, 265);

ASSERT_EQ("5: [14: [244: [], 245: []], "

"15: [255 'no children node': []], "

"16: [264: [], 266: [], "

@@ -167,7 +168,7 @@ TEST_F(FrameTreeTest, Shape) {

"[365: [455: [555: []]]], 268: []]]",

GetTreeState(&frame_tree));

- frame_tree.RemoveFrame(5, 15);

+ frame_tree.RemoveFrame(NULL, 5, 15);

ASSERT_EQ("5: [14: [244: [], 245: []], "

"16: [264: [], 266: [], "

"267 'node with deep subtree': "

« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »