Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove DCHECK, hits too often in unit tests. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/frame_tree_node.h ('K') | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/frame_host/frame_tree_unittest.cc » ('j') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index cf5d906f9e68ecec3c555dab6272cdcafa8a9b89..37b61b4fadf33f20ebe736497138bb582e3d40a7 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -21,8 +21,7 @@ FrameTreeNode::FrameTreeNode(Navigator* navigator,
RenderWidgetHostDelegate* render_widget_delegate,
RenderFrameHostManager::Delegate* manager_delegate,
int64 frame_id,
- const std::string& name,
- scoped_ptr<RenderFrameHostImpl> render_frame_host)
+ const std::string& name)
: navigator_(navigator),
render_manager_(render_frame_delegate,
render_view_delegate,
@@ -32,7 +31,7 @@ FrameTreeNode::FrameTreeNode(Navigator* navigator,
frame_id_(frame_id),
frame_name_(name),
owns_render_frame_host_(true),
- render_frame_host_(render_frame_host.release()) {
+ render_frame_host_(NULL) {
}
FrameTreeNode::~FrameTreeNode() {
« content/browser/frame_host/frame_tree_node.h ('K') | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/frame_host/frame_tree_unittest.cc » ('j') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698