Move out DidStartProvisionalLoad from WebContentsImpl into Navigator.

content/browser/frame_host/navigator_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 
 namespace content {
 
 class RenderFrameHost;
 
 // A delegate API used by Navigator to notify its embedder of navigation
 // related events.
 class NavigatorDelegate {
-  // TODO(nasko): This class will be used to dispatch notifications to
-  // WebContentsImpl, such as DidStartProvisionalLoad and
-  // NotifyNavigationStateChanged. Longer term, most of the
-  // NavigationControllerDelegate methods will likely move here.
+ public:
+  virtual void DidStartProvisionalLoad(

[Charlie Reis, 2013/11/21 21:59:32]

This is where these methods should be documented.

Also, we should probably remove their equivalents from RenderViewHostDelegate,
right?

[nasko, 2013/11/22 01:02:34]

Done.

+      RenderFrameHostImpl* render_frame_host,
+      int64 frame_id,
+      int64 parent_frame_id,
+      bool is_main_frame,
+      const GURL& validated_url,
+      bool is_error_page,
+      bool is_iframe_srcdoc) = 0;

[Charlie Reis, 2013/11/21 21:59:32]

These should have default implementations that do nothing, so that we don't need
to define them in places like InterstitialPageImpl.  (There's a precedent for
that in places like web_contents_delegate.h.)

[nasko, 2013/11/22 01:02:34]

Done.

+
+  virtual void NotifyProvisionalChangeToMainFrameUrl(
+      RenderFrameHostImpl* render_frame_host,
+      const GURL& url) = 0;
+
+  virtual void NotifyNavigationStateChanged(unsigned changed_flags) = 0;
+
 };
 
 }  // namspace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_