Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes based on Charlie's latest review. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 10
11 class GURL;
12
11 namespace content { 13 namespace content {
12 14
13 class NavigationControllerImpl; 15 class NavigationControllerImpl;
14 class NavigatorDelegate; 16 class NavigatorDelegate;
17 class RenderFrameHostImpl;
15 18
16 // Implementations of this interface are responsible for performing navigations 19 // Implementations of this interface are responsible for performing navigations
17 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode 20 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode
18 // objects that are using it and will be released once all nodes that use it are 21 // objects that are using it and will be released once all nodes that use it are
19 // freed. The Navigator is bound to a single frame tree and cannot be used by 22 // freed. The Navigator is bound to a single frame tree and cannot be used by
20 // multiple instances of FrameTree. 23 // multiple instances of FrameTree.
21 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad 24 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad
22 // from WebContentsImpl to this interface. 25 // from WebContentsImpl to this interface.
23 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> { 26 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
24 public: 27 public:
28 // The RenderFrameHostImpl started a provisional load.
29 virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
30 int64 frame_id,
31 int64 parent_frame_id,
32 bool main_frame,
33 const GURL& url) {};
25 34
26 protected: 35 protected:
27 friend class base::RefCounted<Navigator>; 36 friend class base::RefCounted<Navigator>;
28 virtual ~Navigator() {} 37 virtual ~Navigator() {}
29 }; 38 };
30 39
31 } // namespace content 40 } // namespace content
32 41
33 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 42 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698