Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6572)

Unified Diff: chrome/browser/metrics/antivirus_metrics_provider_win.h

Issue 2631583002: Trim version and extraneus parts from AntiVirus product names. (Closed)
Patch Set: remove unneeded code Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/antivirus_metrics_provider_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/antivirus_metrics_provider_win.h
diff --git a/chrome/browser/metrics/antivirus_metrics_provider_win.h b/chrome/browser/metrics/antivirus_metrics_provider_win.h
index 0bf86852e9c5bf28e4a0f36f110eecd39837b1ef..272a87d2fcde6a29bbde08501e57e79cdbb33e97 100644
--- a/chrome/browser/metrics/antivirus_metrics_provider_win.h
+++ b/chrome/browser/metrics/antivirus_metrics_provider_win.h
@@ -85,6 +85,10 @@ class AntiVirusMetricsProvider : public metrics::MetricsProvider {
static std::vector<AvProduct> GetAntiVirusProductsOnFileThread();
+ // Removes anything extraneous from the end of the product name such as
+ // versions, years, or anything containing numbers to make it more constant.
+ static std::string TrimVersionOfAvProductName(const std::string& av_product);
+
// Called when metrics are done being gathered from the FILE thread.
// |done_callback| is the callback that should be called once all metrics are
// gathered.
@@ -102,6 +106,8 @@ class AntiVirusMetricsProvider : public metrics::MetricsProvider {
base::WeakPtrFactory<AntiVirusMetricsProvider> weak_ptr_factory_;
FRIEND_TEST_ALL_PREFIXES(AntiVirusMetricsProviderTest, GetMetricsFullName);
+ FRIEND_TEST_ALL_PREFIXES(AntiVirusMetricsProviderSimpleTest,
+ StripProductVersion);
DISALLOW_COPY_AND_ASSIGN(AntiVirusMetricsProvider);
};
« no previous file with comments | « no previous file | chrome/browser/metrics/antivirus_metrics_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698