Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/metrics/antivirus_metrics_provider_win.h

Issue 2631583002: Trim version and extraneus parts from AntiVirus product names. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/antivirus_metrics_provider_win.h
diff --git a/chrome/browser/metrics/antivirus_metrics_provider_win.h b/chrome/browser/metrics/antivirus_metrics_provider_win.h
index 0bf86852e9c5bf28e4a0f36f110eecd39837b1ef..95863a8d8fb1a87a2e44f926c1b29762591dc2d9 100644
--- a/chrome/browser/metrics/antivirus_metrics_provider_win.h
+++ b/chrome/browser/metrics/antivirus_metrics_provider_win.h
@@ -85,6 +85,8 @@ class AntiVirusMetricsProvider : public metrics::MetricsProvider {
static std::vector<AvProduct> GetAntiVirusProductsOnFileThread();
+ static std::string TrimVersionOfAvProductName(const std::string& av_product);
rkaplow 2017/01/12 23:18:56 hm, I'd add a small comment on some idea of what k
Will Harris 2017/01/12 23:23:59 Acknowledged. Once we agree what the algorithm is
Will Harris 2017/01/12 23:39:06 Done.
+
// Called when metrics are done being gathered from the FILE thread.
// |done_callback| is the callback that should be called once all metrics are
// gathered.
@@ -102,6 +104,8 @@ class AntiVirusMetricsProvider : public metrics::MetricsProvider {
base::WeakPtrFactory<AntiVirusMetricsProvider> weak_ptr_factory_;
FRIEND_TEST_ALL_PREFIXES(AntiVirusMetricsProviderTest, GetMetricsFullName);
+ FRIEND_TEST_ALL_PREFIXES(AntiVirusMetricsProviderSimpleTest,
+ StripProductVersion);
DISALLOW_COPY_AND_ASSIGN(AntiVirusMetricsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698