Add a timezone utility file to base/.

Add a timezone utility file to base/.

Currently there's just one function exported, which checks the system timezone and returns a 2-character ASCII country code for it.

BUG=303368
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235823

[Evan Stade, 2013-10-22 00:42:41]

Let me know your thoughts on the location of this functionality. If you have no
objections I'll write some tests.

[brettw, 2013-10-22 17:27:41]

Don't the country names need to be localized? I would not expect to see
"Europe/Prague" if I was in the Czech republic, for example.

[Evan Stade, 2013-10-22 17:36:07]

On 2013/10/22 17:27:41, brettw wrote:
> Don't the country names need to be localized? I would not expect to see
> "Europe/Prague" if I was in the Czech republic, for example.

No, these are ICU timezone IDs, not display strings.

[brettw, 2013-10-22 21:09:25]

Oh, I see. Seems OK to add this kind of thing.

[Evan Stade, 2013-10-22 21:51:57]

OK, ready for review.

[Evan Stade, 2013-10-24 12:22:34]

On 2013/10/22 21:51:57, Evan Stade wrote:
> OK, ready for review.

ping Brett.

[Evan Stade, 2013-10-25 19:33:35]

Jungshik, could you review please?

[jungshik at Google, 2013-10-28 17:20:49]

On 2013/10/25 19:33:35, Evan Stade wrote:
> Jungshik, could you review please?

Sorry for the delay. Could you tell me what the motivation for this function is?
 Is this for use in CrOS?

[Evan Stade, 2013-10-28 18:27:29]

On 2013/10/28 17:20:49, Jungshik Shin wrote:
> On 2013/10/25 19:33:35, Evan Stade wrote:
> > Jungshik, could you review please?
> 
> Sorry for the delay. Could you tell me what the motivation for this function
is?
>  Is this for use in CrOS?

see http://code.google.com/p/chromium/issues/detail?id=303368

[jungshik at Google, 2013-10-28 20:56:06]

On 2013/10/28 18:27:29, Evan Stade wrote:
> On 2013/10/28 17:20:49, Jungshik Shin wrote:
> > On 2013/10/25 19:33:35, Evan Stade wrote:
> > > Jungshik, could you review please?
> > 
> > Sorry for the delay. Could you tell me what the motivation for this function
> is?
> >  Is this for use in CrOS?
> 
> see http://code.google.com/p/chromium/issues/detail?id=303368

Oh. Sorry that I didn't follow the link in the CL description. On Chrome OS,
currently, this wouldn't work as well as it could until we change the timezone
selection UI ( http://crbug.com/245519 ) because the current UI does not list
all the Olson tz ids. On other platforms, it'd work better. 

Anyway, LGTM

[jungshik at Google, 2013-10-28 21:01:18]

https://codereview.chromium.org/26315008/diff/703001/base/i18n/timezone.cc
File base/i18n/timezone.cc (right):

https://codereview.chromium.org/26315008/diff/703001/base/i18n/timezone.cc#ne...
base/i18n/timezone.cc:603: string16 olson_code(id.getBuffer(), id.length());
BTW, you can use UnicodeString::toUTF8String. ( http://goo.gl/29nHqN ) if you
like to.

[Evan Stade, 2013-10-28 22:08:42]

https://codereview.chromium.org/26315008/diff/703001/base/i18n/timezone.cc
File base/i18n/timezone.cc (right):

https://codereview.chromium.org/26315008/diff/703001/base/i18n/timezone.cc#ne...
base/i18n/timezone.cc:603: string16 olson_code(id.getBuffer(), id.length());
On 2013/10/28 21:01:19, Jungshik Shin wrote:
> BTW, you can use UnicodeString::toUTF8String. ( http://goo.gl/29nHqN ) if you
> like to.
>  

done, thanks for the pointer.

[commit-bot: I haz the power, 2013-10-28 22:11:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/883001

[commit-bot: I haz the power, 2013-10-28 23:05:08]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Evan Stade, 2013-11-01 19:22:10]

+thakis for base.gyp change

[Nico, 2013-11-01 23:43:41]

base.gyp lgtm

[commit-bot: I haz the power, 2013-11-04 21:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/883001

[commit-bot: I haz the power, 2013-11-04 22:44:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-11-05 20:22:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1143001

[commit-bot: I haz the power, 2013-11-05 21:22:20]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-11-05 21:47:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1143001

[commit-bot: I haz the power, 2013-11-05 22:37:16]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_aosp.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-07 17:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1433001

[commit-bot: I haz the power, 2013-11-08 00:50:22]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-11-13 00:32:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1743001

[Ilya Sherman, 2013-11-13 00:54:20]

https://chromiumcodereview.appspot.com/26315008/diff/1743001/base/i18n/timezo...
File base/i18n/timezone.h (right):

https://chromiumcodereview.appspot.com/26315008/diff/1743001/base/i18n/timezo...
base/i18n/timezone.h:17: BASE_I18N_EXPORT std::string
CountryForCurrentTimezone();
nit: IMO "CountryCodeForCurrentTimezone()" would be a better name for this
method.

[commit-bot: I haz the power, 2013-11-13 01:19:41]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-14 23:39:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1183003

[commit-bot: I haz the power, 2013-11-15 01:08:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1183003

[Evan Stade, 2013-11-15 01:18:26]

https://codereview.chromium.org/26315008/diff/1743001/base/i18n/timezone.h
File base/i18n/timezone.h (right):

https://codereview.chromium.org/26315008/diff/1743001/base/i18n/timezone.h#ne...
base/i18n/timezone.h:17: BASE_I18N_EXPORT std::string
CountryForCurrentTimezone();
On 2013/11/13 00:54:21, Ilya Sherman wrote:
> nit: IMO "CountryCodeForCurrentTimezone()" would be a better name for this
> method.

Done.

[commit-bot: I haz the power, 2013-11-15 03:46:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1183003

[commit-bot: I haz the power, 2013-11-15 07:34:11]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-15 07:38:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/1183003

[commit-bot: I haz the power, 2013-11-15 09:37:52]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-15 22:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/2423001

[commit-bot: I haz the power, 2013-11-16 00:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/2423001

[commit-bot: I haz the power, 2013-11-16 03:04:55]

Retried try job too often on mac_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-18 19:14:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/26315008/2783001

[commit-bot: I haz the power, 2013-11-18 21:52:18]

Change committed as 235823