Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 26315007: Adjust Settings UI for Chrome Now's Geolocation Source (Closed)

Created:
7 years, 2 months ago by robliao
Modified:
7 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adjust Settings UI for Chrome Now's Geolocation Source BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228326

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
chrome/browser/resources/options/geolocation_options.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
robliao
7 years, 2 months ago (2013-10-07 23:37:15 UTC) #1
vadimt
lgtm
7 years, 2 months ago (2013-10-07 23:42:50 UTC) #2
robliao
jhawkins: Please provide owner approval for this CL. Thanks!
7 years, 2 months ago (2013-10-08 17:29:04 UTC) #3
rgustafson
lgtm
7 years, 2 months ago (2013-10-08 18:24:14 UTC) #4
robliao
Ping!
7 years, 2 months ago (2013-10-09 17:33:23 UTC) #5
James Hawkins
The bug you linked is very nebulous, so I have no idea how this CL ...
7 years, 2 months ago (2013-10-09 18:05:47 UTC) #6
robliao
On 2013/10/09 18:05:47, James Hawkins wrote: > The bug you linked is very nebulous, so ...
7 years, 2 months ago (2013-10-09 18:12:02 UTC) #7
James Hawkins
https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js File chrome/browser/resources/options/geolocation_options.js (right): https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js#newcode27 chrome/browser/resources/options/geolocation_options.js:27: GeolocationOptions.showGeolocationOption = function() {}; This file looks like dead ...
7 years, 2 months ago (2013-10-11 17:54:53 UTC) #8
robliao
https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js File chrome/browser/resources/options/geolocation_options.js (right): https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js#newcode27 chrome/browser/resources/options/geolocation_options.js:27: GeolocationOptions.showGeolocationOption = function() {}; This is a transitional step ...
7 years, 2 months ago (2013-10-11 17:58:12 UTC) #9
James Hawkins
On 2013/10/11 17:58:12, Robert Liao wrote: > https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js > File chrome/browser/resources/options/geolocation_options.js (right): > > https://codereview.chromium.org/26315007/diff/1/chrome/browser/resources/options/geolocation_options.js#newcode27 ...
7 years, 2 months ago (2013-10-11 18:01:26 UTC) #10
robliao
On 2013/10/11 18:01:26, James Hawkins wrote: > On 2013/10/11 17:58:12, Robert Liao wrote: > > ...
7 years, 2 months ago (2013-10-11 18:07:34 UTC) #11
James Hawkins
On 2013/10/11 18:07:34, Robert Liao wrote: > On 2013/10/11 18:01:26, James Hawkins wrote: > > ...
7 years, 2 months ago (2013-10-11 18:12:55 UTC) #12
robliao
7 years, 2 months ago (2013-10-11 18:42:35 UTC) #13
robliao
On 2013/10/11 18:42:35, Robert Liao wrote: Done!
7 years, 2 months ago (2013-10-11 18:45:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/26315007/22001
7 years, 2 months ago (2013-10-11 21:33:01 UTC) #15
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 07:15:43 UTC) #16
Message was sent while issue was closed.
Change committed as 228326

Powered by Google App Engine
This is Rietveld 408576698