Issue 2631453004: Fix assertion failure in the background compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2631453004: Fix assertion failure in the background compiler. (Closed)

Created:
3 years, 11 months ago by Florian Schneider

Modified:
3 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix assertion failure in the background compiler. When running with hot-reload, the background compiler tries to disable code that already has been disabled by hot-reload. Skip calling DisableDartCode if the code is already disabled. Fixes #28361. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1613cf210842f3ff670ae52b4081c33af413a1c4

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

3 years, 11 months ago (2017-01-12 23:14:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1613cf210842f3ff670ae52b4081c33af413a1c4 (presubmit successful).