Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: content/browser/webrtc/webrtc_browsertest.cc

Issue 2631433002: Rename RTCPeerConnection.updateIce to setConfiguration and make it work. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webrtc/webrtc_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_browsertest.cc b/content/browser/webrtc/webrtc_browsertest.cc
index 5504377138e5d7ebf478b354e01a54385e8621cc..cc0d2556448fdfae823754e23fa2691b41f3a7bf 100644
--- a/content/browser/webrtc/webrtc_browsertest.cc
+++ b/content/browser/webrtc/webrtc_browsertest.cc
@@ -45,6 +45,12 @@ class MAYBE_WebRtcBrowserTest : public WebRtcContentBrowserTestBase {
void MakeTypicalPeerConnectionCall(const std::string& javascript) {
MakeTypicalCall(javascript, "/media/peerconnection-call.html");
}
+
+ void SetConfigurationTest(const std::string& javascript) {
+ // This doesn't actually "make a call", it just loads the page, executes
+ // the javascript and waits for "OK".
+ MakeTypicalCall(javascript, "/media/peerconnection-setConfiguration.html");
+ }
};
// These tests will make a complete PeerConnection-based call and verify that
@@ -202,4 +208,15 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallInsideIframe) {
MakeTypicalPeerConnectionCall("callInsideIframe({video: true, audio:true});");
}
+// Tests that SetConfiguration succeeds and triggers an ICE restart on the next
+// offer as described by JSEP.
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, SetConfiguration) {
+ SetConfigurationTest("testSetConfiguration();");
+}
+
+// Tests the error conditions of SetConfiguration as described by webrtc-pc.
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, SetConfigurationErrors) {
+ SetConfigurationTest("testSetConfigurationErrors();");
+}
+
} // namespace content
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | content/renderer/media/mock_peer_connection_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698