third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2631433002: Rename RTCPeerConnection.updateIce to setConfiguration and make it work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2631433002: Rename RTCPeerConnection.updateIce to setConfiguration and make it work. (Closed)

Patch Set: Simplifying signature of WebRTCPeerConnectionHandler::setConfiguration. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/data/media/peerconnection-setConfiguration.html ('K') | « content/test/data/media/peerconnection-setConfiguration.html ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index 746fba4a85a6aedacb6430be5e8b928a181ee0cc..94b89f430d6d628f62ff3a24f5a5a3d23dbb26f7 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -108,10 +108,9 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

String signalingState() const;

- void updateIce(ExecutionContext*,

- const RTCConfiguration&,

- const Dictionary&,

- ExceptionState&);

+ void setConfiguration(ExecutionContext*,

+ const RTCConfiguration&,

+ ExceptionState&);

// Certificate management

// http://w3c.github.io/webrtc-pc/#sec.cert-mgmt